feat: integrate all supported rocketchat attributes for alertmanagerconfig CR #8016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2025
|
I can't see how the failing e2e tests are related to this PR |
heliapb
reviewed
Oct 10, 2025
|
Anything else that is missing or should be changed? |
|
@simonpasquier as requested I have dropped the file attributes even that I still don't get why these attributes are fine for other providers than Rocket.Chat. |
tboerger
force-pushed
the
rocketchat-mapping
branch
2 times, most recently
from
94d937e to
5a54a7b
Compare
metalmatze
previously approved these changes
Oct 20, 2025
tboerger
force-pushed
the
rocketchat-mapping
branch
from
5a54a7b to
177e1a8
Compare
|
@heliapb just did that and pushed the fix. |
|
@simonpasquier anything else you want to have changed? Or are we ready to go for it? :) |
heliapb
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the AlertmanagerConfig resource does not map all required fileds into the Alertmanager, with this change all currently supported attributes should be added.
I have no idea if it is OK to change this on both API versions, if there is something obviously wrong for you please tell me, it's my first contribution to this project.
Closes: #8009
Closes: #8008
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Added basic unit test.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.