CHANGE/BUGFIX: validate label selectors to prevent reconciliation failures #7916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashpai
force-pushed
the
label-validate
branch
from
547113e to
652b0f0
Compare
slashpai
force-pushed
the
label-validate
branch
from
652b0f0 to
4334b1e
Compare
slashpai
changed the title
slashpai
force-pushed
the
label-validate
branch
4 times, most recently
from
517c5ec to
9a0de5c
Compare
yes working on it |
…lures When label selector fields like serviceMonitorSelector/serviceMonitorNamespaceSelector contain invalid label keys/values (>63 chars or invalid characters), reconciliation would fail. This change adds validation before selector processing to gracefully handle invalid selectors and provide clear error messages. Fixes: prometheus-operator#7915 Assisted-by: Cursor Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai
force-pushed
the
label-validate
branch
from
9a0de5c to
3e62334
Compare
slashpai
changed the title
|
I will work on rebase once we are ok with changes. @simonpasquier can you review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes an existing issue (bug or feature), use the following keyword:
When label selector fields like serviceMonitorSelector/serviceMonitorNamespaceSelector
contain invalid label keys/values (>63 chars or invalid characters),
reconciliation would fail.
This change adds validation before selector processing to gracefully handle
invalid selectors and provide clear error messages.
Fixes: #7915
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.