Add CR Validation for requested limits/requests #7907
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
|
|
||
| // ValidateResourceRequirements validates that resource requests do not exceed limits. | ||
| func ValidateResourceRequirements(resources v1.ResourceRequirements) error { |
There was a problem hiding this comment.
I assume that you intended to use this for all 3 CRDs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request introduces basic CR validation to take place at operator deployment time, ensuring that CPU and memory request/limits are valid before admitting the operator. This is useful for avoiding scenarios where the operator deployment succeeds but then fails to create CRs due to the invalid memory definitions, thereby potentially becoming a silent failure where a helm release of prometheus-operator succeeds but subsequently fails to create CRs.
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Authored unit tests, tested via company internal CI/CD
Changelog entry