feat: add kal maxlength #7895
Draft
feat: add kal maxlength #7895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
heliapb
force-pushed
the
feat/maxlenght_kal
branch
from
7d3b0bc to
f2f4608
Compare
| // Each Secret is added to the StatefulSet definition as a volume named `secret-<secret-name>`. | ||
| // The Secrets are mounted into `/etc/alertmanager/secrets/<secret-name>` in the 'alertmanager' container. | ||
| // +kubebuilder:validation:MaxItems=50 | ||
| // +kubebuilder:validation:items:MaxLength=253 |
There was a problem hiding this comment.
I think that secret names can't exceed 63 chars. For the max number of secrets, I'm not sure what a reasonable limit would be TBH.
| // Each ConfigMap is added to the StatefulSet definition as a volume named `configmap-<configmap-name>`. | ||
| // The ConfigMaps are mounted into `/etc/alertmanager/configmaps/<configmap-name>` in the 'alertmanager' container. | ||
| // +kubebuilder:validation:MaxItems=50 | ||
| // +kubebuilder:validation:items:MaxLength=253 |
| Host string `json:"host"` | ||
| // Defines the host's port, it can be a literal port number or a port name. | ||
| // +kubebuilder:validation:MinLength=1 | ||
| // +kubebuilder:validation:MaxLength=5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From issue #7870, add https://github.com/kubernetes-sigs/kube-api-linter/blob/main/docs/linters.md#maxlength
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.