Skip to content

collector: call PdhGetRawCounterArrayW twice to get the correct amount of bytes needed.#2183

Draft
jkroepke wants to merge 4 commits into
prometheus-community:masterfrom
jkroepke:check_size
Draft

collector: call PdhGetRawCounterArrayW twice to get the correct amount of bytes needed.#2183
jkroepke wants to merge 4 commits into
prometheus-community:masterfrom
jkroepke:check_size

Conversation

@jkroepke
Copy link
Copy Markdown
Member

@jkroepke jkroepke commented Aug 18, 2025

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes and the area they affect
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

@johanot
Copy link
Copy Markdown
Contributor

johanot commented Oct 29, 2025

@jkroepke did this PR stall due to lack of testers? :) Do you have a build of this branch we could potentially use for testing internally here?

@jkroepke
Copy link
Copy Markdown
Member Author

@johanot Generally yes.

Reason for the stall PR is that comment: #2176 (comment) - that this does not help.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…t of bytes needed.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spurious dips/zeros across multiple monotonic windows_process_* counters (Alloy v1.10.1 / windows_exporter v0.30.8)

2 participants