Add function to use TLS when pushing to gateway#994
Add function to use TLS when pushing to gateway#994Roymprog wants to merge 1 commit intoprometheus:masterfrom
Conversation
csmarchbanks
left a comment
There was a problem hiding this comment.
Rather than create a second function could we add another argument for verify_mode to tls_auth_handler?
|
We could, the reason I didn't do that was the name of the function. The name I'd propose keeping one function called |
csmarchbanks
left a comment
There was a problem hiding this comment.
Ahh right, that makes sense, and I think having an auth specific handler is nice.
What would this function provide over just using an https scheme in push_to_gateway? I guess the use case is for if you need to specify the cafile and verify mode?
That can be done. It's how I'm doing it right now. If you want to go that route, it would be better to make |
|
I might be missing something as well, but perhaps this is a bug? I believe |
|
The |
|
That makes sense, thank you. Adding a custom context to I am still thinking about it some and happy to hear other opinions, or advantages/disadvantages of that approach to what you have here. My main concern with this PR is that having two tls related handlers will be confusing. |
Closes #982