Drop support for EOL Python 2.7 and 3.4-3.5#718
Drop support for EOL Python 2.7 and 3.4-3.5#718csmarchbanks merged 4 commits intoprometheus:masterfrom
Conversation
|
Thanks! This will close #717 (just making a reference for the future). I posted that to the -dev mailing list yesterday, and am waiting to hear if there are significant concerns from the community before moving forward with review/merge on this. If I don't hear anything within a week at the most we can certainly move forward. |
|
I haven't heard any concerns on the other issue, so I plan to review this sometime this week! |
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
This looks awesome, thanks for all your work! I left a couple comments/questions, but they are pretty minor. I might try to get a second set of eyes to make sure I am not missing any python 2/3 conversion differences.
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
👍 from me, double checking with a second reviewer, then will merge. Thanks again!
2 participants
Fixes #717.
Follow on from #706 (comment).
Python 2.7 and 3.4 - 3.5 are EOL:
https://endoflife.date/python
Here's the pip installs for prometheus_client from PyPI for October 2021 showing under 2% usage:
Source:
pip install -U pypistats && pypistats python_minor prometheus_client --last-monthIn fact, 2.7 + 3.4 + 3.5 usage combined is under 2% = 1.57%.
Also upgraded Python syntax with https://github.com/asottile/pyupgrade
--py36-plus, and removed universal wheels, only needed for suporting both Python 2 and 3.