mark_process_dead respects old env var #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leohemsted
pushed a commit
to alphagov/notifications-admin
that referenced
this pull request
Apr 8, 2021
we saw exceptions on prod that I think might have caused a worker that is being terminated to die ungracefully. While I'm not sure if this is an actual problem that changed behaviour (app instances crashing and restarting), at the very least it definitely polluted the logs and obscured any actual issues we were having. https://github.com/prometheus/client_python/releases/tag/v0.10.0 see the pending fix for this problem here: prometheus/client_python#644
Some users use mark_process_dead without going through any of the __init__() logic which sets the new environment variable. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
csmarchbanks
force-pushed
the
fix-mark_process_dead-old-env-var
branch
from
1d68ee7 to
9d745ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users use mark_process_dead without going through any of the
__init__()logic which sets the new environment variable.I chose not to put in the warnings in another place as a user will go
through the deprecation path somewhere already.
Fixes #643