Skip to content

Support for namespace in graphite bridge#56

Merged
brian-brazil merged 2 commits into
prometheus:masterfrom
kvikas:master
Oct 4, 2015
Merged

Support for namespace in graphite bridge#56
brian-brazil merged 2 commits into
prometheus:masterfrom
kvikas:master

Conversation

@kvikas

@kvikas kvikas commented Oct 3, 2015

Copy link
Copy Markdown
  1. An optional prefix parameter in bridge.graphite.GraphiteBridge.push().
  2. prefix is prepended to metrics name before sending to graphite server.
  3. Unit test.

Issue #49

1. An optional `prefix` parameter in `bridge.graphite.GraphiteBridge.push()`.
2. `prefix` is prepended to metrics name before sending to graphite server.
3. Unit test.
@kvikas kvikas changed the title Support for namespace in graphite bridge #49 Support for namespace in graphite bridge Oct 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start() needs this option too.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

1. Added an optional parameter `prefix` to `bridge.graphite.GraphiteBridge.push()`.
2. Initialize _RegularPush with `prefix`.
brian-brazil added a commit that referenced this pull request Oct 4, 2015
Support for namespace in graphite bridge
@brian-brazil brian-brazil merged commit fc5a6e3 into prometheus:master Oct 4, 2015
@brian-brazil

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants