Skip to content

flake8 test passing#373

Merged
brian-brazil merged 2 commits into
prometheus:masterfrom
tusharmakkar08:flake8-test-pass
Feb 20, 2019
Merged

flake8 test passing#373
brian-brazil merged 2 commits into
prometheus:masterfrom
tusharmakkar08:flake8-test-pass

Conversation

@tusharmakkar08

Copy link
Copy Markdown
Contributor

Hey @brian-brazil

Earlier flake8 test were failing.
screen shot 2019-02-15 at 8 01 45 pm

I have fixed the tests.
screen shot 2019-02-15 at 7 56 12 pm

P.S: This is my first PR on this repo. Let me know if I have missed anything.
Thanks.

@tusharmakkar08 tusharmakkar08 force-pushed the flake8-test-pass branch 3 times, most recently from 2250e13 to bf24524 Compare February 15, 2019 14:40
Author: tusharmakkar08 [tusharmakkar08@gmail.com]
Signed-off-by: Tushar Makkar <tushar.makkar@vyom.com>
Comment thread tests/test_parser.py Outdated
Comment thread prometheus_client/core.py
@tusharmakkar08

Copy link
Copy Markdown
Contributor Author

Hey @brian-brazil

Did the corresponding changes to make the PR compliant.

Thanks.

Author: tusharmakkar08 [tusharmakkar08@gmail.com]
Signed-off-by: Tushar Makkar <tushar.makkar@vyom.com>
@brian-brazil brian-brazil merged commit 3cb4c92 into prometheus:master Feb 20, 2019
@brian-brazil

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants