Skip to content

Conversation

@Chadys
Copy link

@Chadys Chadys commented Oct 30, 2025

Fixes #1088

Finally got the time to propose what I had in mind :)

I added a utility view for easy inclusion of a metrics endpoint inside a Django project.

I also added some explanation about django-prometheus and the difference between what it provides and the new view.
I hope the difference is clear that way.

@Chadys
Copy link
Author

Chadys commented Oct 30, 2025

I can't seem to satisfy both isort and flake8_import_order, hence the CI error

Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but generally looks reasonable to me, thanks and apologies for the slow review!

Signed-off-by: Julie Rymer <rymerjulie.pro@gmail.com>
@Chadys
Copy link
Author

Chadys commented Dec 21, 2025

No worries, volunteer's work knows no clock ;)
Thanks for the review, should be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Django explicit support

2 participants