additional improve MetricSnapshots.Builder performance#985
Merged
dhoard merged 1 commit intoprometheus:mainfrom Sep 19, 2024
Merged
Conversation
Signed-off-by: Andrey Burov <burov4j@yandex.ru>
burov4j
force-pushed
the
metrics-snapshots-performance-improvement
branch
from
607fe0c to
a1b9506
Compare
dhoard
approved these changes
Sep 19, 2024
Collaborator
|
@burov4j thanks for the PR! |
This was referenced Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
io.prometheus.metrics.model.registry.PrometheusRegistry.scrapehas O(n^2) complexity: higher size of the listmultiCollectorsgenerates higher amount ofsnapshotsin theio.prometheus.metrics.model.snapshots.MetricSnapshots.Builderclass on each loop iteration.Because of this we have x100 times slower metrics scrape in our project on production.
This PR gave us good performance improvement: #963
But it's not enough, because the complexity is still O(n^2). The current PR resolves the performance issue.