Skip to content

Dropwizard: Pass on labels when no custom mapping matched - #447

Merged
brian-brazil merged 1 commit into
prometheus:masterfrom
twz123:fix-dropwizard-custommapping-fallback
Dec 17, 2018
Merged

Dropwizard: Pass on labels when no custom mapping matched#447
brian-brazil merged 1 commit into
prometheus:masterfrom
twz123:fix-dropwizard-custommapping-fallback

Conversation

@twz123

@twz123 twz123 commented Dec 17, 2018

Copy link
Copy Markdown
Contributor

In case of no matching MapperConfig, quantiles were broken, since the CustomMappingSampleBuilder swallowed up the labels.

Signed-off-by: Tom Wieczorek <t.wieczorek@yieldlab.de>
@brian-brazil
brian-brazil merged commit e1913a0 into prometheus:master Dec 17, 2018
@brian-brazil

Copy link
Copy Markdown
Contributor

Thanks!

@twz123
twz123 deleted the fix-dropwizard-custommapping-fallback branch December 19, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants