Fix documentation for push and pushAdd methods. - #137
Closed
rohitagarwal003 wants to merge 1 commit into
Closed
Conversation
rohitagarwal003
force-pushed
the
push-pushAdd-documentation
branch
from
August 18, 2016 06:38
9843dc8 to
bab2aa4
Compare
Contributor
|
Thanks for finding this. It's actually the implementation that's wrong, could you switch it around? |
Contributor
Author
|
I thought so too. But I didn't because it would change the behavior for existing users. But if you are okay with doing that, I can update the PR. |
rohitagarwal003
force-pushed
the
push-pushAdd-documentation
branch
from
August 18, 2016 23:17
bab2aa4 to
f3e8aea
Compare
According to https://github.com/prometheus/pushgateway/blob/0.3.0/README.md#post-method > POST works exactly like the PUT method but only metrics with the same name as > the newly pushed metrics are replaced (among those with the same grouping > key). push uses POST and pushAdd uses PUT. push replaces only metrics with the same name under a job and grouping key. pushAdd replaces all metrics under a job and grouping key. The method names are unfortunate.
rohitagarwal003
force-pushed
the
push-pushAdd-documentation
branch
from
August 18, 2016 23:18
f3e8aea to
b30d9e8
Compare
rohitagarwal003
added a commit
to rohitagarwal003/client_java
that referenced
this pull request
Aug 18, 2016
According to https://github.com/prometheus/pushgateway/blob/0.3.0/README.md#post-method > POST works exactly like the PUT method but only metrics with the same name as the newly pushed metrics are replaced (among those with the same grouping key).
Contributor
Author
|
Created #138 in case we want to do that. |
Contributor
|
Closing in lieu of #138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://github.com/prometheus/pushgateway/blob/0.3.0/README.md#post-method
push uses POST and pushAdd uses PUT.
push replaces only metrics with the same name under a job and grouping key.
pushAdd replaces all metrics under a job and grouping key.
The method names are unfortunate.