Following #137 and #138, push and pushAll have been reversed.
We were using push in the way that was working, but not according to the documentation, obviously. After upgrade (we should have checked the changelog...), we spent some time figuring out why some metrics were nullified, and then changed it to pushAll.
However, any Prometheus java client user will have its Prometheus fail silently just by upgrading the library. It should be nice to rename and/or deprecate both methods instead in order to force developers to acknowledge this change. As it as been pointed out, those names are confusing.
Maybe only have one push method with a mandatory param overrideWholeGroup or fullGroup?
Following #137 and #138,
pushandpushAllhave been reversed.We were using
pushin the way that was working, but not according to the documentation, obviously. After upgrade (we should have checked the changelog...), we spent some time figuring out why some metrics were nullified, and then changed it topushAll.However, any Prometheus java client user will have its Prometheus fail silently just by upgrading the library. It should be nice to rename and/or deprecate both methods instead in order to force developers to acknowledge this change. As it as been pointed out, those names are confusing.
Maybe only have one
pushmethod with a mandatory paramoverrideWholeGrouporfullGroup?