Fix hash instability, file collision, and sort performance#1826
Merged
Conversation
…ontroller Silent file loss when deploying from Flux sources with nested directories When reading files from a Flux source path, the code was keying each file by its bare filename rather than its path relative to the source root. If two files in different subdirectories shared the same name, the second one silently overwrote the first, causing part of the content to be dropped without any error. The fix uses the relative path as the key. Non-deterministic hash for DriftExclusion ordering SortedDriftExclusions.Less() compared entries using only their Paths field. Two entries with identical paths but different Target fields compared as equal, so the sort was free to place them in any order. Because the sorted slice feeds directly into the spec hash used by ClusterPromotionReconciler, the hash could differ between runs for semantically identical specs, triggering spurious promotion re-evaluations. The sort now includes Target (Group, Version, Kind, Namespace, Name) as a stable tiebreaker. Profile spec hash was non-deterministic for map fields and used a slow renderer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silent file loss when deploying from Flux sources with nested directories When reading files from a Flux source path, the code was keying each file by its bare filename rather than its path relative to the source root. If two files in different subdirectories shared the same name, the second one silently overwrote the first, causing part of the content to be dropped without any error. The fix uses the relative path as the key.
Non-deterministic hash for DriftExclusion ordering SortedDriftExclusions.Less() compared entries using only their Paths field. Two entries with identical paths but different Target fields compared as equal, so the sort was free to place them in any order. Because the sorted slice feeds directly into the spec hash used by ClusterPromotionReconciler, the hash could differ between runs for semantically identical specs, triggering spurious promotion re-evaluations. The sort now includes Target (Group, Version, Kind, Namespace, Name) as a stable tiebreaker.
Profile spec hash was non-deterministic for map fields and used a slow renderer