Skip to content

Commit 3fc19ea

Browse files
Add missing lock to ensure thread-safe mutations of _activeInnerStreams in VirtualConnectionClient.cs
1 parent f2c3047 commit 3fc19ea

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/Microsoft.AspNetCore.NodeServices/HostingModels/VirtualConnections/VirtualConnectionClient.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,11 @@ public Stream OpenVirtualConnection()
4646

4747
var id = Interlocked.Increment(ref _nextInnerStreamId);
4848
var newInnerStream = new VirtualConnection(id, this);
49-
_activeInnerStreams.Add(id, newInnerStream);
49+
lock (_activeInnerStreams)
50+
{
51+
_activeInnerStreams.Add(id, newInnerStream);
52+
}
53+
5054
return newInnerStream;
5155
}
5256

0 commit comments

Comments
 (0)