Normal parsing causes config directives to be appended to the end of … #1870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…their container set. <Directory> configs are prepended, though. To preserve both sets of behaviors better, mod_ifsession needs to use the appropriate merge flags for the different directive types, rather than always prepending, as it does now.
|
Should this behavior be configurable? Consider that, at present, mod_ifsession would merge a config directive via prepending to the set. And that means that that directive would be found first, before the previously-existing directives. Which might be the expected/desired behavior of such mod_ifsession-managed configurations. To better decide, I'll need to do some testing with mod_ifsession using order-sensitive directives, such as those from mod_rewrite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…their container set. configs are prepended, though.
To preserve both sets of behaviors better, mod_ifsession needs to use the appropriate merge flags for the different directive types, rather than always prepending, as it does now.
See 29507be for where the current behavior originated, and why (i.e. too much development focus on sections without keeping other configs in mind).