-
-
Notifications
You must be signed in to change notification settings - Fork 224
Replace libsignal-protocol-c with libomemo-c #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Received those patches via PM and mailinglist from Stefan. Comments (to Stefan): Don't forget that we use present tense in commit messages (Replace not Replaced). I also added the (quite valuable) info that you added to the email but not to the patch files themselves. And CI sais no :) |
|
@jubalh: Nice! :) Can you help to update libomemo-c to latest XEP-0384 version? At this time: 0.8.3 (2022-01-18). Ticket here: |
|
@sjaeckel do we want an ifdef or just switch to libomemo-c? |
|
https://github.com/dino/libomemo-c/releases/tag/v0.5.1 has been released. It contains dino/libomemo-c@bf9daf2. |
|
@jubalh: Thanks for 0.5.1: |
The library libsignal-protocol-c is not maintained. This commit will replace the dependency libsignal-protocol-c with libomemo-c. On 2025-02-07 a new version of protobuf-c has been uploaded to Debian. This new version induced a bug for libsignal-protocol-c and libomemo-c: * Bug#1095352: libomemo-c: FTBFS [1] * Bug#1095353: libsignal-protocol-c: FTBFS [2] (Thanks to Dino team and Debian Maintainer it's solved) libomemo-c [3] is a fork of libsignal-protocol-c [4] maintained by the Dino team. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095352 [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095353 [3] https://github.com/dino/libomemo-c [4] https://github.com/signalapp/libsignal-protocol-c Note: Commits squashed and commit message edited by @jubalh.
Fixed missing includeds
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Let's just hope it never breaks its API and/or ABI. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
4dd4b1c to
b4a1528
Compare
The library libsignal-protocol-c is not maintained. This commit will replace the dependency libsignal-protocol-c with libomemo-c.
On 2025-02-07 a new version of protobuf-c has been uploaded to Debian. This new version induced a bug for libsignal-protocol-c and libomemo-c:
(Thanks to Dino team and Debian Maintainer it's solved)
libomemo-c [3] is a fork of libsignal-protocol-c [4] maintained by the Dino team.
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095352
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095353
[3] https://github.com/dino/libomemo-c
[4] https://github.com/signalapp/libsignal-protocol-c
Note:
Commits squashed and commit message edited by @jubalh.