Skip to content

Using different colors to indicate the state of OMEMO messages #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Using different colors to indicate the state of OMEMO messages #2000

wants to merge 8 commits into from

Conversation

@andreaz98
Copy link

@andreaz98 andreaz98 commented Oct 12, 2024 •
edited
Loading

Using different colors to indicate the state of OMEMO messages

The main goal of this MarkDown is to organize the ideas for this feature that has the potential to become an interesting and useful feature for every profanity's user, IMHO. The chosen color must not cause eyestrain on long OMEMO chats sessions. I'll try to keep this document updated as I make progress in the development.

TODO list

  • Understand how to implement the option /omemo colors on|off (default: off).
  • Implement /omemo colors on|off.
  • Understand how /save works, getting a light grasp of it is sufficient.
  • When /omemo colors on, implement sent OMEMO messages are white, received OMEMO messages are darker white.
  • Understand how to insert colors, on, and off in the autocompletion.
  • Based on the currently loaded theme, text of the received OMEMO messages will be a bit darker than the text for sent OMEMO messages.
  • /omemo colors reverse on|off: sent OMEMO messages will be a bit darker than the received OMEMO messages.
  • The user can set a color of her choice, e.g. /omemo colors set yellow for received OMEMO messages will be yellow regardless the loaded theme. If the /omemo colors reverse on is set, the sent OMEMO messages will be yellow.
  • Code is Ready for review
  • Support OMEMO colors on MUC. NOTE: profanity doesn't support OMEMO on MUCs yet.

Further ideas:

  • opaqueness of non-OMEMO messages. Text of non-OMEMO messages will result opaque to the eyes of the reader.

Not so sure about this one:

  • background color around OMEMO messages

DISCLAIMER

This is an open source project. This feature is not about me, it is about us. Please, feel free to contribute by sharing ideas, developing code, commenting etc. :)

@jubalh
Copy link
Member

jubalh commented Oct 15, 2024 •
edited
Loading

Hi!
Thanks for your PR.

There won't be a need for the OMEMO-colors.md file. You can just have this as a comment here in the PR or having it in a GitHub issue in case you don't create a PR for a topic.

So I'll just leave this PR open and start reviewing once you set it to ready. Have fun coding! Keep in mind that the PR might or might not be merged based on the implementation and usefulness.

@andreaz98
Adds preference PREF_OMEMO_COLORS
dd92898 
This commit adds the possibility to save the preference for `/omemo colors on|off`.
@andreaz98
Removed OMEMO-colors.md
116e85f
@andreaz98
Copy link
Author

andreaz98 commented Oct 15, 2024

Hi! Thanks for your PR.

There won't be a need for the OMEMO-colors.md file. You can just have this as a comment here in the PR or having it in a GitHub issue in case you don't create a PR for a topic.

So I'll just leave this PR open and start reviewing once you set it to ready. Have fun coding! Keep in mind that the PR might or might not be merged based on the implementation and usefulness.

Hi!
I understand the PR might and might not be merged based upon implementation and usefulness :)

@jubalh jubalh changed the title [FEATURE] feature/OMEMO-colors Using different colors to indicate the state of OMEMO messages Oct 17, 2024
@jubalh
Copy link
Member

jubalh commented Aug 22, 2025

@andreaz98 any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

discussion feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andreaz98 @jubalh