Repository navigation
Fix fatal TypeError when dynamic tag returns array (ACF gallery / rep… - #35
Open
cgdmohamed wants to merge 1 commit into
Open
cgdmohamed wants to merge 1 commit into
cgdmohamed wants to merge 1 commit into
Conversation
|
Report this to the official Elementor repo. The author of this plugin will not accept any changes to the plugin as it is a one on one copy of the original elementor pro. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Display condition string comparators strictly type-hint
$actual_valueas string.However many dynamic sources in real Elementor usage (e.g. ACF Gallery,
Repeater, Relationship, multi-select taxonomies) return array values.
On PHP 8+, this causes a fatal TypeError before comparator logic executes,
breaking frontend rendering when using conditions like "is not empty".
Fix
$actual_valueto accept non-scalar values.Result