updates for Processing 4#263
Conversation
|
Thanks for the PR! @jeremydouglass Please have a look. |
|
Sorry for the delay -- been extremely ill, catching up. |
|
Looks like I also still need to migrate this repo from Travis-CI to GitHub actions. sigh. |
| i1.loadPixels(); | ||
| int[] ip1 = i1.pixels; | ||
| for (int n = 0; n < ip0.length; n++) { | ||
| int pxl0 = ip0[n] |
There was a problem hiding this comment.
That's weird. Blame says that I introduced this breaking typo when I merged a large set of codacy style changes --
but then that build passed on the CI server!
https://travis-ci.org/github/processing-r/Processing.R/builds/569579118
I'm not sure how that is possible, unless that build didn't perform the e2e ImageUtils phase at all. Something to look at when setting up Actions.
There was a problem hiding this comment.
Nevermind, that build actually failed in the log, it just displayed as passed for some reason. ugh.
jeremydouglass
left a comment
jeremydouglass
left a comment
There was a problem hiding this comment.
I think I can see that Processing 4 has moved to PConstants.MACOS, e.g.
processing/processing4@fab6b59
Going forward, any reason we should add both MACOSX / MACOS internally to our available PConstants? Currently we just import PConstants from the processing 3 core, attach them to BuiltinApplet and then extend RLangPApplet with them.
|
Nope, That being said, I wouldn't recommend supporting 3.x any longer. Apple's aggressive OS changes alone will make it nearly impossible to run Processing there in the near future, if not already. |
|
Any progress here? I can help test it if needed. |
|
@gaocegege sorry this dropped off my radar. I've build and run through the examples / tests -- everything still works on Processing 3, but could you give the release I upload a quick try on the latest Processing 4? I don't have a 10.14 mac available at the moment to confirm. |
|
Closed #262 |
3 participants
Changes included:
framefield