Skip to content
This repository was archived by the owner on Dec 5, 2018. It is now read-only.

Conversation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const doesn't technically do anything in ES5 (although as browsers are adding ES2015/ES7-8 support, that's changing), and as this is not user code, but library code, we will not be redeclaring these values at any point in the file. Since the scope is already function scope, let's make these var.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I already said I'd remove const when it's about to merge

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a new PR, I'm simply filing everything we discussed "as text" where they apply to the code, so think of all of these as administrative comments (i.e.: "a change is needed here") that we can use for tracking purposes, not "I told you to change these, why haven't you changed them yet". If any of these lines still show up after the final rewrite, then we know we've forgotten something. It's a nice feature of github PRs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var

Change `in` condition 'random' to 'lerp' for local util **pjsCheck()**.
[x, y, z, amt] = arguments
Function shorthand for PVector's prototype object.
Changed 'lerp' to 'noLoop' in obj,
b/c lerp() exists in both PApplet & PVector!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants