Skip to content

Conversation

@DeerajTheepshi
Copy link

@DeerajTheepshi DeerajTheepshi commented Mar 15, 2019

@SyamSundarKirubakaran
Copy link

installation of Contribution

Can you make this more clear.!? Also, specify the issue that this PR closes.

@DeerajTheepshi
Copy link
Author

installation of Contribution

Can you make this more clear.!? Also, specify the issue that this PR closes.

By Contribution , I meant, mode/library/tools/Examples installation

@kfrajer
Copy link

kfrajer commented May 12, 2019

Hi Deeraj, I checked the PR and it requires more testing. The changes seems to work for the update action for the trivial case. However, it does not trigger for remove and it does trigger for install but only after downloading step and not after completing the installation of the library. I only tested this when installing/updating/removing libraries. I have not tested this for tools, examples or mode installs.

One suggestion is to place your change at the end of the following function in the same file: private void finishInstall(boolean error). You can test it in the different scenarios and provide details on your tests. This information will make easier to evaluate the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants