BugFix for Duplicate Library Conflicts. #5126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of multiple matching libraries (possible duplicates) only the required one is chosen, by making a guess based on the other, guaranteed, libraries in use. In a first pass, the guaranteed libraries are cached. In a second pass, unresolved package-library mappings are generated, based on pass 1.
Author
|
any thoughts, suggestions? |
…o bugfix-duplicateLibraryConflict
Author
|
For Debugging, I am using this debug sketchbook. Download: Sketchbook_DebugDuplicateLibraryConflicts.zip
I could only test on windows so far, but i expect it to work on other systems as well. |
…o bugfix-duplicateLibraryConflict # Conflicts: # java/src/processing/mode/java/JavaBuild.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
(this is my first PR for processing. So im not sure if i did everything right so far ... pls let me know.)
This PR tackles the "Duplicate Library"-Conflict.
The problem occurs, when libraries are based on same 3rd party libraries (same or different version), like Fisica and Box2D for Processing both use jBox2d.
Fix:
In case of multiple matching libraries ( = possible duplicates) only the
required one is chosen, by making a guess based on the other, guaranteed,
libraries in use.
In a first pass, the guaranteed libraries are cached.
In a second pass, unresolved package-library mappings are generated, based on pass 1.
old Error message:
fixed:
Not sure if these verbose print-warnings are necessary, but i kept them for the moment. Most users dont have to deal with possible duplicates anyways i guess.