Make color, fill, stroke et al. thread-safe: #3077 #4774
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calc***color variables deleted;colorCalcnow returns afloat[] {r,g,b,a}array, with values from 0 to 1, like the old calc[RGBA] variables. The graycolormethods don't bother with colorCalc at all.The fill and stroke methods were also non thread-safe and values could easily pass between them.
I ran a number of tests with random inputs to the new
colorfunctions and they differed by one (eg.ffE5E5E5→ffE6E6E6) from the previous version in a tiny number (seven in 10 million) of cases due to different rounding but were otherwise identical.Fixes #3077.