Prevent NPEs when tab document is null#4596
Merged
Merged
Conversation
JavaMode visits all tabs on sketch load to extract breakpoints, so doc is always set (except when running Tweak mode; it sets docs to null to force reload). Other modes have null docs until the tabs are visited manually. Fixes processing#4555
Contributor
|
Thanks; maybe we'll do a 3.1.3 with this. |
Contributor
Author
|
There are two other places where null doc can be a problem. One is main error checker loop, it uses docs to get tab contents. It will spit an exception into console, but keep running. Other place is Rename, it will also spit an exception and do nothing. I need to revise this later and make sure there are some clear rules how document works. Edit: this is only a problem in JavaMode, after running Tweak Mode |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaMode visits all tabs on sketch load to extract breakpoints, so doc
is always set (except when running Tweak mode; it sets docs to null to
force reload). Other modes have null docs until the tabs are visited
manually.
Fixes #4555