Skip to content

Make Comment/Uncomment trigger on numpad slash#4457

Merged
benfry merged 1 commit into
processing:masterfrom
JakubValtar:comment-key-fix
May 10, 2016
Merged

Make Comment/Uncomment trigger on numpad slash#4457
benfry merged 1 commit into
processing:masterfrom
JakubValtar:comment-key-fix

Conversation

@JakubValtar

Copy link
Copy Markdown
Contributor

No description provided.

@benfry

benfry commented May 9, 2016

Copy link
Copy Markdown
Contributor

Really this is #2199. Are you proposing this as a band-aid until we can get to that one?

@JakubValtar

Copy link
Copy Markdown
Contributor Author

It's not, they are two different keys. I tested on US layout and on Czech layout. Numpad slash is VK_DIVIDE and regular slash is VK_SLASH. And there is no way known to me in their terrible API to add second accelerator key to the menu item.

@benfry

benfry commented May 9, 2016

Copy link
Copy Markdown
Contributor

Heh, I understand that. I'm asking if this a patch to paper over #2199 so that it works on your keyboard (and others) until we have a better way of specifying a better shortcut for non-US keyboards?

@JakubValtar

JakubValtar commented May 9, 2016

Copy link
Copy Markdown
Contributor Author

No, this has nothing to do with locale. It does not work on any numpad, because slash on numpad is considered to be a different key than slash in the letter part on every keyboard. Menu item is set up for VK_SLASH, but that does not cover numpad slash key, which is VK_DIVIDE. I believe that unless we have one listener for each key, it will not work with both keys.

@JakubValtar

Copy link
Copy Markdown
Contributor Author

Just to make things clear: this is about numpad slash. Comment/Uncomment in other apps is often mapped to Ctrl+Slash and it always works with this key. This PR adds listener for this slash in all layouts.

keyboard2

@benfry benfry merged commit aad493e into processing:master May 10, 2016
@benfry

benfry commented May 10, 2016

Copy link
Copy Markdown
Contributor

I can't stop laughing that even though I said I understood that these were different keys, you still had to make an image for me. We miss you back here in Boston.

@JakubValtar

Copy link
Copy Markdown
Contributor Author

Looks like their API is so bad it makes people dumb. I spent an hour with it before I figured it out and look at this.

@JakubValtar JakubValtar deleted the comment-key-fix branch May 13, 2016 12:04
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants