Make Comment/Uncomment trigger on numpad slash#4457
Conversation
|
Really this is #2199. Are you proposing this as a band-aid until we can get to that one? |
|
It's not, they are two different keys. I tested on US layout and on Czech layout. Numpad slash is VK_DIVIDE and regular slash is VK_SLASH. And there is no way known to me in their terrible API to add second accelerator key to the menu item. |
|
Heh, I understand that. I'm asking if this a patch to paper over #2199 so that it works on your keyboard (and others) until we have a better way of specifying a better shortcut for non-US keyboards? |
|
No, this has nothing to do with locale. It does not work on any numpad, because slash on numpad is considered to be a different key than slash in the letter part on every keyboard. Menu item is set up for VK_SLASH, but that does not cover numpad slash key, which is VK_DIVIDE. I believe that unless we have one listener for each key, it will not work with both keys. |
|
I can't stop laughing that even though I said I understood that these were different keys, you still had to make an image for me. We miss you back here in Boston. |
|
Looks like their API is so bad it makes people dumb. I spent an hour with it before I figured it out and look at this. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |

No description provided.