Skip to content

Uncomment identation fix #4249#4313

Merged
benfry merged 1 commit into
processing:masterfrom
DarkPrince304:uncommentFix
May 9, 2016
Merged

Uncomment identation fix #4249#4313
benfry merged 1 commit into
processing:masterfrom
DarkPrince304:uncommentFix

Conversation

@DarkPrince304

Copy link
Copy Markdown
Contributor

Hello,

With this I think the issue #4249 is fixed and uncommenting the lines wont reduce the identation, and it will remain the way it was before uncommenting. :)

Would like to have some review on this!

@JakubValtar

Copy link
Copy Markdown
Contributor

@DarkPrince304 Thanks!

@benfry Let's merge this for 3.1.1

@benfry benfry merged commit 34c5a63 into processing:master May 9, 2016
@benfry

benfry commented May 9, 2016

Copy link
Copy Markdown
Contributor

@JakubValtar also see note I just added here as you're looking into this further.

@JakubValtar

Copy link
Copy Markdown
Contributor

@benfry There was no space being added. However, if there was a space after the slashes, it got deleted (fixed by this PR).

I'm personally used to slashes being added to the left border (zero line offset), now they are added after indent and it makes the code messy. Do you think it would be better idea?

Also the keyboard shortcut doesn't work on my keyboard, I will have to fix it too.

@benfry

benfry commented May 9, 2016

Copy link
Copy Markdown
Contributor

I was used to the slashes going at the beginning of the line, but relented because we got so many requests to change it.

When the new version was contributed, an additional space was added (since that's now the style of many editors... perhaps Sublime in particular?) I removed that with the later commit that was referenced.

@JakubValtar

Copy link
Copy Markdown
Contributor

Okay, now it should be fully functional, I'm just going to fix the keyboard shortcut.

@JakubValtar

Copy link
Copy Markdown
Contributor

Shortcut follow up: #4457

@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants