Bugfix infinite pop ups - #4037
Closed
iamutkarshtiwari wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
You may test the infinite popups by saving a new sketch and then _deleting it's .pde_ file while Processing running alongside. After deletion, when you return back to the Processing editor window a popup appears, click _"No"_ on which prompts the popup again and again. |
Contributor
|
Thanks for this, though we're opting for the solution found in #4762 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixed this issue -> #3965
I have added a _doReloadPrompt boolean flag_ to check if the popup has been prompted atleast once if the user externally _modifies/deletes_ the main file. If the user selects _'No'_ option, the popup closes as expected(no infinite popups). If the user further modifies the file externally, the prompt will appear normally.