Skip to content

Miscellaneous fixes#2865

Merged
benfry merged 6 commits into
processing:masterfrom
federicobond:misc-fixes
Nov 14, 2014
Merged

Miscellaneous fixes#2865
benfry merged 6 commits into
processing:masterfrom
federicobond:misc-fixes

Conversation

@federicobond

Copy link
Copy Markdown
Contributor

I put them all in a single pull request since they involve very small, uncontroversial changes.

  • Remove duplicated allocation of JMenuBar
  • Avoid boxing/unboxing when parsing primitive
  • Avoid inefficient use of new String(String)
  • Use valueOf factory method instead of constructor
  • Add missing static modifier to inner classes
  • Remove unused PresentMode.device instance variable
  • Add volatile modifier to ColorSelector.selector

@federicobond

Copy link
Copy Markdown
Contributor Author

Anything I can do to ease the merge of these changes?

@GKFX

GKFX commented Oct 28, 2014

Copy link
Copy Markdown
Contributor

Please could you undo "Remove duplicated allocation of JMenuBar"? I've already done it at #2382 and it causes a merge clash. Thanks!

@federicobond

Copy link
Copy Markdown
Contributor Author

Sure, but I don't think that is what is causing your merge conflicts because it's the same diff.

@GKFX

GKFX commented Oct 28, 2014

Copy link
Copy Markdown
Contributor

Thanks!

benfry added a commit that referenced this pull request Nov 14, 2014
@benfry benfry merged commit 9dc3bfa into processing:master Nov 14, 2014
@federicobond federicobond deleted the misc-fixes branch November 15, 2014 02:13
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants