Skip to content

Fixes #1936 - Preproc constructor cast fix#2772

Merged
benfry merged 3 commits into
processing:masterfrom
JakubValtar:preproc-constructorCast-fix
Aug 12, 2014
Merged

Fixes #1936 - Preproc constructor cast fix#2772
benfry merged 3 commits into
processing:masterfrom
JakubValtar:preproc-constructorCast-fix

Conversation

@JakubValtar

Copy link
Copy Markdown
Contributor

Fixes #1936. Tokens can be null when Recognizer uses "guess" mode, which was not accounted for. Now fixed.

Fixes processing#1936. Tokens can be null when Recognizer uses "guess" mode, which
was not accounted for.
Changed `float[] parseByte(byte[])` to `float[] parseFloat(byte[])`
benfry added a commit that referenced this pull request Aug 12, 2014
@benfry benfry merged commit ab2fb8c into processing:master Aug 12, 2014
@benfry

benfry commented Aug 12, 2014

Copy link
Copy Markdown
Contributor

Awesome, thank you!

@JakubValtar

Copy link
Copy Markdown
Contributor Author

@benfry Just a note, b848168 changes PApplet public API. Not sure if it can break libraries or cause other complications.

@benfry

benfry commented Aug 19, 2014

Copy link
Copy Markdown
Contributor

Only if it was in use before... it looks like that change is fixing a typo?

@JakubValtar

Copy link
Copy Markdown
Contributor Author

Yes, it is correcting a typo.
Previously you had to write
float[] floatArray = byte(byteArray); corrected to
float[] floatArray = float(byteArray);

@JakubValtar JakubValtar deleted the preproc-constructorCast-fix branch September 12, 2014 12:49
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

combining char/int/etc casts in one statement causes preproc trouble

2 participants