Fixes NPE when writing to disconnected client, Issue #2577#2578
Merged
benfry merged 1 commit intoprocessing:masterfrom Nov 14, 2014
Merged
Fixes NPE when writing to disconnected client, Issue #2577#2578benfry merged 1 commit intoprocessing:masterfrom
benfry merged 1 commit intoprocessing:masterfrom
Conversation
benfry
added a commit
that referenced
this pull request
Nov 14, 2014
Fixes NPE when writing to disconnected client, Issue #2577
Contributor
|
Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In every situation I have tested, checking if the client is active before writing to the client prevents the NPE message but does not change the functionality. I have not been able to create an instance where the act of calling the write method before checking if the client is active has the effect of changing the active() method to return False when it would have otherwise returned True.