Fix #364 if-else autoformatting#2477
Merged
Merged
Conversation
benfry
added a commit
that referenced
this pull request
May 10, 2014
Fix #364 if-else autoformatting
Contributor
|
Fixes #364. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auto-formatting of if-else statements, specifically the new line for else, has bugged me for a long time, but I always though this was the intended formatting style in Processing. Until I saw issue #364 today. So apparantly it is an issue, outstanding!
This pull request fixes the issue at hand, while having no impact on other auto-formatting results as different users have pointed out in issue #1791 in reply to an earlier - now revoked - fix by another user. All different code examples were extensively tested against both 2.1.2 and the patched code. Additional spaces and hard returns are also handled correctly by the patched code. Once again, the result is that the bug is fixed and no other auto-formatting results are impacted.
For a full comparison, see below:
Code examples that neither 2.1.2 or the patched code change after running auto-format:
INITIAL & AUTO-FORMATTED CODE:
Code examples that 2.1.2 and the patched code both change in the exact same way after running auto-format:
INITIAL CODE:
AUTO-FORMATTED CODE (both in 2.1.2 and the patched code):
Code examples that differ in how 2.1.2 and the patched code handle them:
INITIAL CODE:
AUTO-FORMATTED CODE (2.1.2):
AUTO-FORMATTED CODE (patched code):
For your consideration...