Skip to content

Update JavaBuild.java#2273

Merged
benfry merged 1 commit into
processing:masterfrom
GKFX:patch-2
May 10, 2014
Merged

Update JavaBuild.java#2273
benfry merged 1 commit into
processing:masterfrom
GKFX:patch-2

Conversation

@GKFX

@GKFX GKFX commented Dec 18, 2013

Copy link
Copy Markdown
Contributor

Fix bug #8. (import static causes incorrect errors.)

@benfry

benfry commented May 4, 2014

Copy link
Copy Markdown
Contributor

If it's a static import, that should probably be in its own "if" block. As it is, this patch is too confusing for me to be able to know whether it's going to cause a regression or not.

@benfry benfry closed this May 4, 2014
@GKFX

GKFX commented May 5, 2014

Copy link
Copy Markdown
Contributor Author

@benfry I'm confused. I have used a fairly clear if block. I am doing my
GCSEs so I have no free time to make any changes but I will review it in
June.

@benfry benfry reopened this May 10, 2014
benfry added a commit that referenced this pull request May 10, 2014
implement "import static"
@benfry benfry merged commit dfc28df into processing:master May 10, 2014
@benfry

benfry commented May 10, 2014

Copy link
Copy Markdown
Contributor

Fingers crossed...

@GKFX GKFX deleted the patch-2 branch May 13, 2014 17:26
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants