handle spaces properly for processing-java on macOS (fixes #4779)

benfry · benfry · commit a395991e7d90 · 2017-01-29T11:07:41.000-05:00
diff --git a/app/src/processing/app/tools/InstallCommander.java b/app/src/processing/app/tools/InstallCommander.java
@@ -105,7 +105,7 @@ public void run() {
       String classPath = jarList.join(":").replaceAll(javaRoot + "\\/?", "");
 
       writer.println("cd \"" + javaRoot + "\" && " +
-                     Platform.getJavaPath() +
+                     Platform.getJavaPath().replaceAll(" ", "\\\\ ") +
                      " -Djna.nosys=true" +
                      " $OPTION_FOR_HEADLESS_RUN" +
       		           " -cp \"" + classPath + "\"" +
diff --git a/todo.txt b/todo.txt
@@ -20,6 +20,8 @@ X   https://github.com/processing/processing/issues/1601
 X JRE download fails during ant build
 X   https://github.com/processing/processing/issues/4823
 X changed headerType to console (make sure changed back)
+X Spaces not handled correctly in when installing "processing-java" on macOS
+X   https://github.com/processing/processing/issues/4779
 
 _ blank window on startup where the "welcome" screen should be
 _   https://github.com/processing/processing/issues/3933
@@ -37,9 +39,6 @@ _   need to move "is this a sketch?" handling into Mode
 _ fix extension check for other modes
 _   https://github.com/processing/processing/issues/3980
 
-_ Spaces not handled correctly in when installing "processing-java" on macOS
-_   https://github.com/processing/processing/issues/4779
-
 contrib
 X Added the remove filter feature
 X   https://github.com/processing/processing/pull/3890
