better naming, some notes

benfry · benfry · commit a1de8966cbbf · 2016-05-08T20:33:11.000-04:00
diff --git a/app/src/processing/app/Util.java b/app/src/processing/app/Util.java
@@ -668,7 +668,7 @@ static public byte[] gzipEncode(byte[] what) throws IOException {
   }
 
 
-  static public final boolean hasNonAsciiChars(String what) {
+  static public final boolean containsNonASCII(String what) {
     for (char c : what.toCharArray()) {
       if (c < 32 || c > 127) return true;
     }
diff --git a/app/src/processing/app/platform/WindowsPlatform.java b/app/src/processing/app/platform/WindowsPlatform.java
@@ -285,7 +285,7 @@ public File getSettingsFolder() throws Exception {
     } catch (UnsatisfiedLinkError ule) {
       String path = new File("lib").getCanonicalPath();
 
-      String msg = Util.hasNonAsciiChars(path) ?
+      String msg = Util.containsNonASCII(path) ?
         "Please move Processing to a location with only\n" +
         "ASCII characters in the path and try again.\n" +
         "https://github.com/processing/processing/issues/3543" :
diff --git a/app/src/processing/app/ui/Toolkit.java b/app/src/processing/app/ui/Toolkit.java
@@ -991,7 +991,7 @@ static private Font createFont(String filename, int size) throws IOException, Fo
       // This gets the JAVA_HOME for the *local* copy of the JRE installed with
       // Processing. If it's not using the local JRE, it may be because of this
       // launch4j bug: https://github.com/processing/processing/issues/3543
-      if (Util.hasNonAsciiChars(Platform.getJavaHome().getAbsolutePath())) {
+      if (Util.containsNonASCII(Platform.getJavaHome().getAbsolutePath())) {
         msg += "Trying moving Processing\n" +
           "to a location with only ASCII characters in the path.";
       } else {
diff --git a/core/todo.txt b/core/todo.txt
@@ -50,9 +50,6 @@ _ normalize error messages for missing files
 _   https://github.com/processing/processing/issues/4265
 _   https://github.com/processing/processing/pull/4268
 
-
-_ fix menu bar hiding in exported JavaFX apps
-_   just call it around setup time? 
 _ should fullScreen() set width and height to displayWidth/Height
 _   or is that being set/unset used for any state info?
 _ when calling exit(), if sketch has halted w/ exception, force the quit
@@ -94,6 +91,8 @@ _   https://github.com/processing/processing/issues/3753
 
 
 javafx
+_ fix menu bar hiding in exported JavaFX apps
+_   just call it around setup time? 
 _ make wiki about quirks
 _   starving the thread makes things really slow down
 _   keyPressed() is always uppercase, keyTyped() will be correct

Original file line number	Diff line number	Diff line change
`@@ -668,7 +668,7 @@ static public byte[] gzipEncode(byte[] what) throws IOException {`
`668`	`668`	`}`
`669`	`669`
`670`	`670`
`671`		`- static public final boolean hasNonAsciiChars(String what) {`
	`671`	`+ static public final boolean containsNonASCII(String what) {`
`672`	`672`	`for (char c : what.toCharArray()) {`
`673`	`673`	`if (c < 32 \|\| c > 127) return true;`
`674`	`674`	`}`