Skip to content

Commit 9a4db4b

Browse files
committed
fix incorrect mx2/my2 calculations in PImage
1 parent f37de2b commit 9a4db4b

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

core/src/processing/core/PImage.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -533,21 +533,27 @@ public void updatePixels(int x, int y, int w, int h) { // ignore
533533

534534
if (!modified) {
535535
mx1 = PApplet.max(0, x);
536-
mx2 = PApplet.min(width - 1, x2);
536+
//mx2 = PApplet.min(width - 1, x2);
537+
mx2 = PApplet.min(width, x2);
537538
my1 = PApplet.max(0, y);
538-
my2 = PApplet.min(height - 1, y2);
539+
//my2 = PApplet.min(height - 1, y2);
540+
my2 = PApplet.min(height, y2);
539541
modified = true;
540542

541543
} else {
542544
if (x < mx1) mx1 = PApplet.max(0, x);
543-
if (x > mx2) mx2 = PApplet.min(width - 1, x);
545+
//if (x > mx2) mx2 = PApplet.min(width - 1, x);
546+
if (x > mx2) mx2 = PApplet.min(width, x);
544547
if (y < my1) my1 = PApplet.max(0, y);
545-
if (y > my2) my2 = y;
548+
//if (y > my2) my2 = y;
549+
if (y > my2) my2 = PApplet.min(height, y);
546550

547551
if (x2 < mx1) mx1 = PApplet.max(0, x2);
548-
if (x2 > mx2) mx2 = PApplet.min(width - 1, x2);
552+
//if (x2 > mx2) mx2 = PApplet.min(width - 1, x2);
553+
if (x2 > mx2) mx2 = PApplet.min(width, x2);
549554
if (y2 < my1) my1 = PApplet.max(0, y2);
550-
if (y2 > my2) my2 = PApplet.min(height - 1, y2);
555+
//if (y2 > my2) my2 = PApplet.min(height - 1, y2);
556+
if (y2 > my2) my2 = PApplet.min(height, y2);
551557
}
552558
}
553559

0 commit comments

Comments
 (0)