possible additional fix for ghost editors on os x

benfry · benfry · commit 6834eef583de · 2011-03-11T14:07:20.000Z
diff --git a/app/src/processing/app/Base.java b/app/src/processing/app/Base.java
@@ -972,6 +972,7 @@ public boolean handleClose(Editor editor, boolean modeSwitch) {
           editor.setVisible(false);
           editor.dispose();
           activeEditor = null;
+          editors.remove(editor);
         } else {
           // Since this wasn't an actual Quit event, call System.exit()
           System.exit(0);
@@ -982,6 +983,7 @@ public boolean handleClose(Editor editor, boolean modeSwitch) {
         defaultFileMenu.insert(sketchbookMenu, 2);
 //        defaultFileMenu.insert(defaultMode.getExamplesMenu(), 3);
         activeEditor = null;
+        editors.remove(editor);
       }
 
     } else {
diff --git a/todo.txt b/todo.txt
@@ -6,6 +6,8 @@ X 'unexpected token void' for any type of error
 X   (due to fallback in preprocessor)
 X   'public' keyword in class declarations breaks syntax checker
 X   http://code.google.com/p/processing/issues/detail?id=551
+X found issue where editor objects were being kept around after closing
+X   particularly on mac os x, since the object wasn't being removed at 1 editor
 
 _ with one sketch open, changing the mode doesn't close the original editor
 _   only affects linux and windows
