Repository navigation
Fix service worker downloading ~100 MB on first visit - #1630
Open
Akshats-git wants to merge 1 commit into
Open
Akshats-git wants to merge 1 commit into
Akshats-git wants to merge 1 commit into
Conversation
The precache pattern pulled in every image and search index (~112 MB) on a first visit. Precache only CSS, JS and fonts (~4 MB) instead. - Cache visited pages with a network-first rule that matches navigations, so they work offline without serving stale pages. - Cache only the search index for the language being used. - Remove the unused ar, pt-br and sk search indices. Fixes processing#1621
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1621
The service worker was precaching every image and search index, so a first visit quietly downloaded ~112 MB (the page itself is ~2.5 MB). It also never cached pages for offline use, because its rule only matched
.htmlURLs and ours end in/.Changes
navigationPreloadso page loads don't wait for the worker to start.ar,pt-brandsksearch indices. Nothing builds or loads them.Testing
Built the site and checked it in Chromium (Playwright) against
npm run preview:npm run check(0 errors),npm test(63 passing) and the production build all pass.The
v1branch has the same config, so it needs the same change. Happy to open a follow-up PR for that.AI use: I used Claude Code to help investigate and validate the changes.