Merged
Conversation
These guidelines are used by default in repositories that don't include specific guidelines.
tbouffard
commented
Jan 28, 2025
|
|
||
| Branch naming is essential for understanding the purpose of the branch and eventually, for automatically adding labels to the PR. | ||
|
|
||
| ### Branch Naming Convention |
Member
Author
There was a problem hiding this comment.
thought: We have specific convention for bpmn-visualization.
I suggest we apply the same conventions in all repositories and use the one describe here as it is commonly used in a large amount of projects.
Do you agree @csouchet?
Current bpmn-visualization convention: https://github.com/process-analytics/bpmn-visualization-js/blob/24963c8693d5dec600c7d4288f523c4ef068ea62/CONTRIBUTING.md#fork--create-a-branch
Member
Author
There was a problem hiding this comment.
OK, I am working on a new PR
csouchet
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These guidelines are used by default in repositories that don't include specific guidelines.