Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prerender/java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: prerender/java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: embedded-jetty-smoke
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 2 contributors

Commits on May 15, 2026

  1. test: drive filter inside embedded Jetty instead of Mockito 

    Mockito mocks on HttpServletRequest/Response don't exercise the real
servlet container: filter chain wiring, URL/query construction, status
and header propagation, static-asset pass-through are all simulated.

Boot Jetty on a free port, register PrerenderFilter via FilterHolder
with init params, mount a tiny servlet for the pass-through case, and
hit the whole thing with a real HttpClient. Upstream Prerender service
remains faked with the already-present WireMock.

Jetty pinned to 11.0.20 to match WireMock 3.5.4's transitive version
and avoid a classpath conflict with Jetty 12.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
    Marcin @claude
    Marcin and claude committed May 15, 2026
    Configuration menu
    Copy the full SHA
    e206679 View commit details
    Browse the repository at this point in the history
Loading