Fix match? that were not detected by RuboCop#174
Merged
grosser merged 1 commit intopremailer:masterfrom Dec 14, 2024
Merged
Conversation
grosser
approved these changes
Dec 13, 2024
Contributor
|
CI disagrees :) |
Maybe because of some false negatives affecting conditionals Ref: rubocop/rubocop-performance#152
tagliala
force-pushed
the
chore/fix-match-missed
branch
from
59cd4fe to
f6addfb
Compare
Contributor
Author
|
Ah, sorry, typo with autocomplete -tokens
+token |
tagliala
commented
Dec 13, 2024
| end | ||
| end | ||
| elsif in_charset or token =~ /@charset/i | ||
| elsif in_charset or /@charset/i.match?(token) |
Contributor
Author
There was a problem hiding this comment.
just to mention, does not seem that the second condition is covered by tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe because of some false negatives affecting conditionals
Ref: rubocop/rubocop-performance#152
Why and what is being done.
Pre-Merge Checklist