Skip to content

Add support for custom TypeScript config filename#618

Merged
emmatown merged 14 commits intopreconstruct:mainfrom
prastoin:main
Mar 24, 2025
Merged

Add support for custom TypeScript config filename#618
emmatown merged 14 commits intopreconstruct:mainfrom
prastoin:main

Conversation

@prastoin
Copy link
Copy Markdown
Contributor

@prastoin prastoin commented Mar 21, 2025

Introduction

This PR is just a suggestion that aims to illustrate this issue #617

As always any suggestions are welcomed !

Closes #617

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 21, 2025

🦋 Changeset detected

Latest commit: 86daadc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (9c1c51b) to head (86daadc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   92.65%   92.89%   +0.23%     
==========================================
  Files          39       39              
  Lines        2096     2110      +14     
  Branches      661      652       -9     
==========================================
+ Hits         1942     1960      +18     
+ Misses        143      139       -4     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emmatown
Copy link
Copy Markdown
Member

While I don't really the use case for this (e.g. in the linked project, the seperate ts configs just seem to be adding more complexity and type-checking time?), adding this seems fine I suppose, could you change the option to be preconstruct.tsconfig and add it in https://github.com/preconstruct/preconstruct/blob/main/site/docs/configuration.md#packages-packages?

@prastoin
Copy link
Copy Markdown
Contributor Author

prastoin commented Mar 24, 2025

Hey @emmatown, hope you're doing good ! Thanks for your time and the review
Updated the PR to follow your points
Also raised a request for more information regarding the findConfig dynamic usage motivations
I've implemented your recommendation from my understanding
Please let me know !
See you

@prastoin
Copy link
Copy Markdown
Contributor Author

prastoin commented Mar 24, 2025

in the linked project, the seperate ts configs just seem to be adding more complexity and type-checking time

Yes exactly, uses TypeScript project references

@emmatown emmatown merged commit 4620b09 into preconstruct:main Mar 24, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom TypeScript config filename

2 participants