Add support for custom TypeScript config filename#618
Add support for custom TypeScript config filename#618emmatown merged 14 commits intopreconstruct:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 86daadc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 92.65% 92.89% +0.23%
==========================================
Files 39 39
Lines 2096 2110 +14
Branches 661 652 -9
==========================================
+ Hits 1942 1960 +18
+ Misses 143 139 -4
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
While I don't really the use case for this (e.g. in the linked project, the seperate ts configs just seem to be adding more complexity and type-checking time?), adding this seems fine I suppose, could you change the option to be |
packages/cli/src/rollup-plugins/typescript-declarations/common.ts
Outdated
Show resolved
Hide resolved
|
Hey @emmatown, hope you're doing good ! Thanks for your time and the review |
Yes exactly, uses TypeScript project references |
Introduction
This PR is just a suggestion that aims to illustrate this issue #617
As always any suggestions are welcomed !
Closes #617