Skip to content

A linter for Sceptre stack configs #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asottile merged 1 commit into from
Mar 8, 2022
Merged

A linter for Sceptre stack configs #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions all-repos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,3 +214,4 @@
- https://github.com/shssoichiro/oxipng
- https://github.com/datarootsio/databooks
- https://github.com/standard/standard
- https://github.com/Sceptre/sceptrelint

@asottile asottile Mar 1, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Sceptre/sceptrelint/blob/aee222f5565cb91748b8af23f09a0916600888e1/.pre-commit-hooks.yaml#L5-L6

  • pass_filenames: true is the default
  • always_run: true generally should not be set -- pre-commit will pass filenames for changed things to the tool so it runs selectively (otherwise when no files are changed the tool will receive 0 filenames and probably do the wrong thing)

@zaro0508 zaro0508 Mar 3, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tip @asottile . Those configs have been removed.