Repository navigation
A linter for Sceptre stack configs - #638
Merged
Merged
Conversation
Add a reference to the Sceptre pre-commit linter. This linter checks sceptre stack configurations[1] [1] https://docs.sceptre-project.org/dev/docs/stack_config.html
asottile
reviewed
Mar 1, 2022
| - https://github.com/shssoichiro/oxipng | ||
| - https://github.com/datarootsio/databooks | ||
| - https://github.com/standard/standard | ||
| - https://github.com/Sceptre/sceptrelint |
Member
There was a problem hiding this comment.
pass_filenames: trueis the defaultalways_run: truegenerally should not be set -- pre-commit will pass filenames for changed things to the tool so it runs selectively (otherwise when no files are changed the tool will receive 0 filenames and probably do the wrong thing)
Contributor
Author
There was a problem hiding this comment.
thanks for the tip @asottile . Those configs have been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a reference to the Sceptre pre-commit linter. This linter checks
sceptre stack configurations[1]
[1] https://docs.sceptre-project.org/dev/docs/stack_config.html