Skip to content

Do not run legacy script again when this is the one being executed #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asottile merged 3 commits into from
Mar 30, 2019
Merged

Do not run legacy script again when this is the one being executed #981

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd61269
Do not run legacy script again when this is the one being executed
Mar 27, 2019
ec72cb7
assert that the pre-commit script being executed is not the legacy
Mar 29, 2019
bbc3130
Produce slightly more helpful message
asottile Mar 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pre_commit/resources/hook-tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ def _norm_exe(exe):


def _run_legacy():
if __file__.endswith('.legacy'):
raise SystemExit(
"bug: pre-commit's script is installed in migration mode\n"
'run `pre-commit install -f --hook-type {}` to fix this\n\n'
'Please report this bug at '
'https://github.com/pre-commit/pre-commit/issues'.format(
HOOK_TYPE,
),
)

if HOOK_TYPE == 'pre-push':
stdin = getattr(sys.stdin, 'buffer', sys.stdin).read()
else:
Expand Down