Skip to content

Conversation

@asottile
Copy link
Member

@asottile asottile commented Aug 6, 2018

No description provided.

@asottile
Copy link
Member Author

asottile commented Aug 6, 2018

Resolves #808

@asottile
Copy link
Member Author

asottile commented Aug 6, 2018

CC @s0undt3ch

@s0undt3ch
Copy link
Contributor

Thanks!

@s0undt3ch
Copy link
Contributor

Planning on releasing soon?

@asottile
Copy link
Member Author

asottile commented Aug 6, 2018 via email

@asottile
Copy link
Member Author

asottile commented Aug 6, 2018

This has been released as part of 1.10.5 🎉

@s0undt3ch
Copy link
Contributor

Awesome!


try:
return _git_dir('--git-common-dir')
except CalledProcessError: # pragma: no cover (git < 2.5)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider compatibility git < 2.5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you seeing issues with git < 2.5? This branch is intended to allow that to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants