Skip to content

Fix specify config file not work while installing - #604

Merged
asottile merged 3 commits into
pre-commit:masterfrom
coldnight:master
Sep 5, 2017
Merged

asottile merged 3 commits into
pre-commit:masterfrom
coldnight:master

Conversation

@coldnight

Copy link
Copy Markdown
Contributor

Via pre-commit install -c .other-config.yaml

Via `pre-commit install -c .other-config.yaml`
@coldnight

Copy link
Copy Markdown
Contributor Author

@asottile Please review and I don't how to handle the hash things here.

@asottile

asottile commented Sep 5, 2017

Copy link
Copy Markdown
Member

Looks great! I haven't changed the hashes in forever and don't think they need to change -- iirc they're only if the calling construct of pre-commit changes.

Could you add a quick test that demonstrates that this works? There should be some prior art in tests/commands/install_uninstall_test.py

@asottile

asottile commented Sep 5, 2017

Copy link
Copy Markdown
Member

Oh neat, I was able to add a test to your branch directly.

@asottile
asottile merged commit 98ca85e into pre-commit:master Sep 5, 2017
@asottile

asottile commented Sep 5, 2017

Copy link
Copy Markdown
Member

Thanks for the PR! This will make it into the next release I have (I have some plans to add a few more things into this one as well)

droctothorpe pushed a commit to droctothorpe/pre-commit that referenced this pull request Mar 23, 2022
…e-config

[pre-commit.ci] pre-commit autoupdate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants