Repository navigation
chore(deps): bump nodeenv version to >= 1.12.0 - #3792
lewisbirks wants to merge 1 commit into
Conversation
Signed-off-by: lewisbirks <22620804+lewisbirks@users.noreply.github.com>
|
the minimum is just that. a version which pre-commit can work with (as it does just fine if |
I can't speak to this exact case, but what I was trying to do in #3793 was bump versions for software to ensure that downstream (pre-commit) maintainers could rely on features in identify/pre-commit which might not be available in all versions, like pre-commit/identify#601 .
|
|
again you seem to not understand what a minimum version is. setup.cfg is there to specify the minimum possible working versions of dependencies by your logic there should be a version bump and new release for every single identify change. which is the entire reason identify is separate so that you don't have to do that |
nodeenv 1.12.0 skips node.js pre-releases when resolving the latest version (release notes).
Older versions pick the newest entry in node's release index, which is currently
27.0.0-alpha.0.0.0. They then crash withValueError: invalid literal for int() with base 10: '0-alpha'.This affects any
language: nodehook that has nolanguage_versionset and no system node, for examplemarkdownlint-cli(see igorshubovych/markdownlint-cli#681).Raising the minimum makes pip installs pick up the fix. This is quite a big version bump however I didn't notice any breaking changes but it would be good if someone more familiar with pre-commit could look over and confirm this.